Fix to locations #32423
Fix to locations #32423
Conversation
Quintis1212
requested review from
adamziel,
draganescu,
getdave,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Hi, @Quintis1212 Thanks for working on this PR. Can you rebase the latest trunk on top of your branch to resolve conflicts? You can find more details about this Git workflow here - https://developer.wordpress.org/block-editor/contributors/code/git-workflow/#keeping-your-branch-up-to-date. |
There was a problem hiding this comment.
The issue here is that part of the file you are editing has moved to the sidebar directory.
I think your best move is to
- Update your fork with the latest from Gutenberg. Be sure to
git pull origin trunkthe latesttrunkfrom your fork if you use @talldan's Github UI method. - Create a new branch in your fork.
- Redo your changes - they should be made here.
- Push this new branch up.
- Close Fix to locations #32423.
I think you're very close to getting this ready to merge 🤞 .
|
Hey @Quintis1212 👋 - is there anything I can do to help you get this merged? Current requirements to get this ready to merge are still #32423 (review). Happy to sync up on Core WordPress Slack if that would help you to work through the necessary steps. |
|
Hi @Quintis1212. It looks like perhaps you've been unable to find time to follow up here. No problem. If you're still interesting in working on this PR let me know, otherwise I'll take this over and spin up a PR which solves the issue. Thanks again for contributing here 🙇 |
|
Update: I raised a PR to supercede this one so I'm going to close it out. |
new fix to "Navigation screen: regression of improved menu locations select placeholder #30330
Closes #30330